Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass postUrl through in frameInfo #229

Merged
merged 1 commit into from
May 2, 2024
Merged

Pass postUrl through in frameInfo #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ninety-ways-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@xmtp/frames-client": patch
---

bumped packages to pass postUrl through in frameInfo
2 changes: 1 addition & 1 deletion packages/frames-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
},
"dependencies": {
"@noble/hashes": "^1.3.3",
"@open-frames/proxy-client": "^0.3.0",
"@open-frames/proxy-client": "^0.3.2",
"@xmtp/proto": "3.51.1",
"long": "^5.2.3"
},
Expand Down
30 changes: 30 additions & 0 deletions packages/frames-client/src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,4 +125,34 @@ describe("signFrameAction", () => {
// Add a long timeout because Vercel cold starts can be slow
{ timeout: 20000 },
);
it(
"sends back the button postUrl for a tx frame in frame info",
async () => {
const frameUrl =
"https://tx-boilerplate-frame-git-main-xmtp-labs.vercel.app/";
const metadata = await framesClient.proxy.readMetadata(frameUrl);
expect(metadata).toBeDefined();
expect(metadata.frameInfo).toMatchObject({
acceptedClients: {
xmtp: "2024-02-09",
farcaster: "vNext",
},
buttons: {
"1": {
label: "Make transaction",
action: "tx",
target:
"https://tx-boilerplate-frame-git-main-xmtp-labs.vercel.app/api/transaction",
postUrl:
"https://tx-boilerplate-frame-git-main-xmtp-labs.vercel.app/api/transaction-success",
},
},
image: {
content:
"https://tx-boilerplate-frame-git-main-xmtp-labs.vercel.app/api/og?transaction=null",
},
});
},
{ timeout: 20000 },
);
});
20 changes: 10 additions & 10 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2925,21 +2925,21 @@ __metadata:
languageName: node
linkType: hard

"@open-frames/proxy-client@npm:^0.3.0":
version: 0.3.0
resolution: "@open-frames/proxy-client@npm:0.3.0"
"@open-frames/proxy-client@npm:^0.3.2":
version: 0.3.2
resolution: "@open-frames/proxy-client@npm:0.3.2"
dependencies:
"@open-frames/proxy-types": "npm:0.2.0"
checksum: 10/cca2f209be860e9328cf7768d3da3672eb5f079c9b27e31536e25cd1a59baeba7a074305a68236a222d7e6c72d7877b3dfcc49c750eb98072438f324b83b75dd
"@open-frames/proxy-types": "npm:0.2.2"
checksum: 10/43a4ee1322625665c93f548fcaf957f52a37e31a9d5f77e1979b3ab127bdd2e3156f632b9d3075f6dabbe9467ac4d5640cd5d82bc4905ee3b2d2771e87d9f9c4
languageName: node
linkType: hard

"@open-frames/proxy-types@npm:0.2.0":
version: 0.2.0
resolution: "@open-frames/proxy-types@npm:0.2.0"
"@open-frames/proxy-types@npm:0.2.2":
version: 0.2.2
resolution: "@open-frames/proxy-types@npm:0.2.2"
peerDependencies:
typescript: ^5.3.3
checksum: 10/7bb09f290624abf75097055dad57657ba244a60f72dec3f839aaa08aeb9b7e98f49a1423f48f98620202ee2c1aa8075e5cfbd0888876f3f277cae98d0e976909
checksum: 10/fc1ba0ccc4e5b5cfc8e9507d25f1e7a0be974068a1fe59d135b0aa17bc1d2f83eeb332a26942d8d3a67f6d6c29ebf4356693738e5f7a975c84cea2f84e5d0687
languageName: node
linkType: hard

Expand Down Expand Up @@ -5408,7 +5408,7 @@ __metadata:
resolution: "@xmtp/frames-client@workspace:packages/frames-client"
dependencies:
"@noble/hashes": "npm:^1.3.3"
"@open-frames/proxy-client": "npm:^0.3.0"
"@open-frames/proxy-client": "npm:^0.3.2"
"@open-frames/types": "npm:^0.1.0"
"@rollup/plugin-terser": "npm:^0.4.4"
"@rollup/plugin-typescript": "npm:^11.1.6"
Expand Down