You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normalize ENS/Base names to lowercase for case-insensitive matching in xmtp.chat input fields.
This ensures that user-provided ENS/Base names, regardless of casing, correctly resolve to the intended profile when creating direct messages, group conversations, or adding members.
Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch. Learn more about Cursor Agents
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Normalize XMTP name resolution and profile map keys to lowercase across helpers.resolveName, hooks.useMemberId, and stores.profiles
Introduce lowercase normalization for input names during resolution and for profile names map keys, applying the normalized value for cache lookups, API calls, and profile combination.
📍Where to Start
Start with the resolveName helper in names.ts, then follow the call path through useMemberId in useMemberId.ts and the profilesStore actions in profiles.ts.
@humanagent would it make sense to also automatically remove "spaces" while the name is being entered? I have seen that many people tried to enter "theglobalstore" at the hackathon and their mobile phones were inserting spaces while spaces aren't allowed in ENS names?!
@humanagent would it make sense to also automatically remove "spaces" while the name is being entered? I have seen that many people tried to enter "theglobalstore" at the hackathon and their mobile phones were inserting spaces while spaces aren't allowed in ENS names?!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Normalize ENS/Base names to lowercase for case-insensitive matching in xmtp.chat input fields.
This ensures that user-provided ENS/Base names, regardless of casing, correctly resolve to the intended profile when creating direct messages, group conversations, or adding members.
Slack Thread