Skip to content

Allow LOCAL with a custom string #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Allow LOCAL with a custom string #491

merged 3 commits into from
Mar 25, 2025

Conversation

nplasterer
Copy link
Contributor

iOS side of xmtp/xmtp-android#170

You can call this now with XMTPEnvironment.customLocalAddress = "string"

Gives the ability to run a physical android app pointing at a local environment.

@nplasterer nplasterer self-assigned this Mar 25, 2025
@nplasterer nplasterer requested a review from a team as a code owner March 25, 2025 02:23
Copy link

macroscopeapp bot commented Mar 25, 2025

Add Custom Local Environment Address Support

Added customLocalAddress configuration option to XMTPEnvironment to allow custom local environment URLs. Modified URL generation logic to use custom address when specified. Updated version from 4.0.1 to 4.0.2.

📍Where to Start

The XMTPEnvironment enum in XMTPEnvironment.swift which contains the core environment configuration changes.


Macroscope summarized d7b536f.

Copy link

macroscopeapp bot commented Mar 25, 2025

Changes in 9c0bc74

  • Refactored URL construction in XMTPiOS module's XMTPEnvironment enum by separating port numbers (:443 and :5556) from host addresses in raw values and moving port handling to the url property implementation
  • Added address computed property to XMTPiOS module's XMTPEnvironment enum to support custom local address overrides

Macroscope summarized 9c0bc74.

@nplasterer nplasterer merged commit 47121e8 into main Mar 25, 2025
2 of 3 checks passed
@nplasterer nplasterer deleted the np/custom-local-url branch March 25, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants