-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SASL2, BIND2, and FAST #1006
base: main
Are you sure you want to change the base?
Conversation
As reccomended by the RFC
d655154
to
7c6e9c4
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Thanks! I will get around to fixing CI and reviewing once I have a bit of time. |
Not to be a pain, but any chance to get this looked at? Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for this!
could you add tests? check the other similar modules
e2e tests would be needed as well
CI is broken but I can have a look eventually - let me know if you have troubles running tests locally but a fix would be awesome
@sonnyp tests added |
No description provided.