Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for ASRC demo guide #365

Merged
merged 18 commits into from
Oct 8, 2024

Conversation

lucianomartin
Copy link
Contributor

@lucianomartin lucianomartin commented Sep 27, 2024

In addition to the changes required by XVC-26, some links in the doc have been updated.

Part of https://xmosjira.atlassian.net/browse/XVC-26

Copy link
Contributor

@shuchitak shuchitak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@mbanth mbanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a few text change suggestions.

doc/programming_guide/asrc/overview.rst Outdated Show resolved Hide resolved
doc/programming_guide/asrc/overview.rst Outdated Show resolved Hide resolved
doc/programming_guide/asrc/overview.rst Outdated Show resolved Hide resolved
doc/programming_guide/asrc/overview.rst Outdated Show resolved Hide resolved
doc/programming_guide/asrc/overview.rst Outdated Show resolved Hide resolved
doc/programming_guide/asrc/overview.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@mbanth mbanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one minor comment which @lucianomartin has already fixed.

The main sources of latency are:

- Large block size used for ASRC processing: this is necessary to minimise latency associated with the intertile context and thread switching overhead.
- Large size of the buffer to which the ASRC output samples are written: a stable level (half full) must be reached before the start of streaming out over USB.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra white space in before the

@lucianomartin lucianomartin merged commit f677508 into xmos:develop Oct 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants