Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc charts #88

Merged
merged 16 commits into from
Sep 28, 2023
Merged

Doc charts #88

merged 16 commits into from
Sep 28, 2023

Conversation

shuchitak
Copy link
Contributor

@shuchitak shuchitak commented Sep 21, 2023

https://xmosjira.atlassian.net/browse/AP-149

In this PR I've added the doc charts generation script to run on Jenkins and archive the output plots in the artifacts.

Next step would be to add the plots to the documentation.

@mbanth mbanth assigned shuchitak and unassigned mbanth Sep 22, 2023
Tests are run for all suported input and output sample freqencies, and for worst case frequency deviation.
Note that not all modules support all input scenarios - these are ignored.

The result of this script is the generation an rst file which is inclorporated into the documentation,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inclorporated -> incorporated.
Also incorporated twice is a bit clunky.

Copy link
Collaborator

@ed-xmos ed-xmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - minor comment only.

@ed-xmos
Copy link
Collaborator

ed-xmos commented Sep 26, 2023

Actually one more comment - might be better to zip the image artefacts. Jenkins artefacts page is pretty cluttered.

@shuchitak shuchitak merged commit fc45721 into develop Sep 28, 2023
4 checks passed
@xross xross deleted the doc_charts branch January 18, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants