Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused include file #22

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

mbruno-xmos
Copy link

This removes the two #include <print.h> lines in debug_printf.c.

This was causing a conflict with a project that had its own print.h
header file, and nothing in print.h is used anyway.

Mike Bruno and others added 5 commits August 29, 2019 09:09
This was causing a conflict with a project that had its own print.h
header file.
Adds long formatting case for use in FreeRTOS+TCP, which uses %l for 32
bit unsigned values.
Replaced the debug_printf function with one derived from the one Xilinx
uses with their standalone BSP. Also added debug_sprintf and
debug_snprintf functions. All three call the same underlying function.
Copy link
Contributor

@mbanth mbanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a substantial and beneficial enhancement to logging functionality. It deserves further review. A copyright date range has become stale. Otherwise I did not identify any changes needed during my very cursory review.

@@ -1,140 +1,480 @@
// Copyright (c) 2014-2016, XMOS Ltd, All rights reserved
// Copyright (c) 2014-2019, XMOS Ltd, All rights reserved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright date range needs updated to 2014-2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants