Fix xmlsec version comparison macro #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roman513
changed the title
Roman513
force-pushed
the
master
branch
2 times, most recently
from
a5954f6 to
14558d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 88.25% 88.27% +0.01%
==========================================
Files 12 12
Lines 2044 2047 +3
==========================================
+ Hits 1804 1807 +3
Misses 240 240
Continue to review full report at Codecov.
|
Use 8 instead of 4 bits for all xmlsec version fields to prevent overflow starting from version number 1.2.32
|
@Roman513 awesome, thank you for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 8 instead of 4 bits for all xmlsec version fields in version comparison macro to prevent compilation errors starting from xmlsec version 1.2.32
Closes #165