bypass freezegun if installed #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

dnozay merged 1 commit into xmlrunner:master from danchr:freezegun

Mar 15, 2019

Contributor

danchr commented Mar 15, 2019

freezegun is simple package frequently used in tests to stop the
clock. When active on a class, xmlrunner reports that all its tests took
zero seconds, which is obviously incorrect. To easily bypass this
without making the code aware of freezegun, we import time.time()
by value.


          bypass freezegun if installed

deb039a

freezegun is simple package frequently used in tests to stop the
clock. When active on a class, xmlrunner reports that all its tests took
zero seconds, which is obviously incorrect. To easily bypass this
without making the code aware of freezegun, we import `time.time()`
by value.

codecov-io commented Mar 15, 2019 •

edited

Loading

Codecov Report

Merging #185 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   99.49%   99.49%   +<.01%     
==========================================
  Files          17       17              
  Lines        1393     1394       +1     
==========================================
+ Hits         1386     1387       +1     
  Misses          7        7

Impacted Files	Coverage Δ
xmlrunner/result.py	`98.33% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed3fb0b...deb039a. Read the comment docs.

coveralls commented Mar 15, 2019

Coverage increased (+0.0004%) to 99.497% when pulling deb039a on danchr:freezegun into ed3fb0b on xmlrunner:master.

8 similar comments

coveralls commented Mar 15, 2019

Coverage increased (+0.0004%) to 99.497% when pulling deb039a on danchr:freezegun into ed3fb0b on xmlrunner:master.

coveralls commented Mar 15, 2019

Coverage increased (+0.0004%) to 99.497% when pulling deb039a on danchr:freezegun into ed3fb0b on xmlrunner:master.

coveralls commented Mar 15, 2019

Coverage increased (+0.0004%) to 99.497% when pulling deb039a on danchr:freezegun into ed3fb0b on xmlrunner:master.

coveralls commented Mar 15, 2019

Coverage increased (+0.0004%) to 99.497% when pulling deb039a on danchr:freezegun into ed3fb0b on xmlrunner:master.

coveralls commented Mar 15, 2019

Coverage increased (+0.0004%) to 99.497% when pulling deb039a on danchr:freezegun into ed3fb0b on xmlrunner:master.

coveralls commented Mar 15, 2019

Coverage increased (+0.0004%) to 99.497% when pulling deb039a on danchr:freezegun into ed3fb0b on xmlrunner:master.

coveralls commented Mar 15, 2019

Coverage increased (+0.0004%) to 99.497% when pulling deb039a on danchr:freezegun into ed3fb0b on xmlrunner:master.

coveralls commented Mar 15, 2019

Coverage increased (+0.0004%) to 99.497% when pulling deb039a on danchr:freezegun into ed3fb0b on xmlrunner:master.

dnozay merged commit b7bfcc4 into xmlrunner:master

jombooth mentioned this pull request

Circumvent freezegun in favor of a real clock where possible #228

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet