Merge pull request jashkenas#1253 from braddunbar/sort-by

Handle equal indices in _.sortBy.
xmbsn · Aug 11, 2013 · db588fa · db588fa
2 parents d67868d + b3985b6
commit db588fa
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/underscore.js b/underscore.js
@@ -306,9 +306,9 @@
     var iterator = lookupIterator(value);
     return _.pluck(_.map(obj, function(value, index, list) {
       return {
-        value : value,
-        index : index,
-        criteria : iterator.call(context, value, index, list)
+        value: value,
+        index: index,
+        criteria: iterator.call(context, value, index, list)
       };
     }).sort(function(left, right) {
       var a = left.criteria;
@@ -317,7 +317,7 @@
         if (a > b || a === void 0) return 1;
         if (a < b || b === void 0) return -1;
       }
-      return left.index < right.index ? -1 : 1;
+      return left.index - right.index;
     }), 'value');
   };