-
Notifications
You must be signed in to change notification settings - Fork 89
upgrade ios sdk to 5.8.1/android sdk to 5.7.0 #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade ios sdk to 5.8.1/android sdk to 5.7.0 #90
Conversation
Have a good day, great to see your hard work! |
@dienhungptit I updated the README. please checkout the diff |
Tks pro. |
@blackbing
how to work on Android and iOS |
Do you install our fork repo?
|
@blackbing I install |
Have you done Android setup? https://github.com/VeryBuy/react-native-line/tree/feat/upgrade-sdk#android-setup |
@blackbing work on iOS when downgrade react-native version 0.67.2 but Android I setup follow you but open popup then display error |
@blackbing you can check in this repo |
@blackbing I found the cause, because it doesn't match the package name. I hope you will update for react native version 0.69 soon |
I see. Our project use react-native@0.67. when we upgrade to 0.69 above, I will take a look the problem. I think it might do some migrate task like this. |
from ver0.68 file AppDelegate.m convert to AppDelegate.mm |
@phuocantd i have error on Android "xmartlabs_react-native-line:compileDebugKotlin". How to fix it |
what's version react native you use? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for contributing!
Sorry for the very late response, the idea is to go back to maintaining the repo.
I suppose you won't be doing any of these changes because of how much time has passed since you opened it.
I will merge these changes to a new branch and work on it to merge it to master
as soon as possible and do a release to make it available to all the devs.
Thank you again!! Your fork was able to help so many developers in the meantime 🙏
... | ||
dependencies { | ||
... | ||
implementation 'com.linecorp.linesdk:linesdk:5.7.0' // <- add this line | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thank you for contributing! The idea is that the final user doesn't need to implement LINE directly, the library takes care of it. So I would remove this block
... | |
dependencies { | |
... | |
implementation 'com.linecorp.linesdk:linesdk:5.7.0' // <- add this line | |
} | |
} |
android { | ||
// Enable Java 1.8 support. | ||
compileOptions { // <- add this block if didn't setup | ||
sourceCompatibility JavaVersion.VERSION_1_8 | ||
targetCompatibility JavaVersion.VERSION_1_8 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice catch! Thank you!!
Anyway, we encourage the users to read the line documentation, since it will be always up-to-date.
upgrade ios sdk to 5.8.1/android sdk to 5.7.0
🔄 Type of change:
✏️ Description:
The library SK is out of date. There are newer version to upgrade. Besides,
IOS
we don't need
use_frameworks!
if react-native >= 0.63.Android
the namespace was changed.
com.linecorp:linesdk
->com.linecorp.linesdk:linesdk:
📌 Notes:
because we don't have publish permission @xmartlabs/react-native-line, so we build the dist and push to our repo.
You can also checkout the commit. https://github.com/VeryBuy/react-native-line/commits/feature/verybuy
✔️Tasks: