Skip to content

upgrade ios sdk to 5.8.1/android sdk to 5.7.0 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

blackbing
Copy link
Contributor

@blackbing blackbing commented May 16, 2022

upgrade ios sdk to 5.8.1/android sdk to 5.7.0

🔄 Type of change:

  • ✨Feature/chore
  • ♻️ Refactor
  • 🔧 Bugfixes

✏️ Description:

The library SK is out of date. There are newer version to upgrade. Besides,

IOS

we don't need use_frameworks! if react-native >= 0.63.

Android

the namespace was changed. com.linecorp:linesdk -> com.linecorp.linesdk:linesdk:


📌 Notes:

  • for anyone who need to use the latest SDK directly, feel free to use our repo
yarn add verybuy/react-native-line#8dcc99d

because we don't have publish permission @xmartlabs/react-native-line, so we build the dist and push to our repo.

You can also checkout the commit. https://github.com/VeryBuy/react-native-line/commits/feature/verybuy


✔️Tasks:

  • we have integrated in our project and it works.

@dienhungptit
Copy link

dienhungptit commented May 17, 2022

Have a good day, great to see your hard work!
I'm currently doing Line Authentication in my React-Native App, and I can not find any good Repo like yours. But I still not implement right in IOS:D Can you make a doc/tutorial on using your repo. Thank you very much.

@blackbing
Copy link
Contributor Author

blackbing commented May 17, 2022

@dienhungptit
Copy link

Tks pro.

@phuocantd
Copy link

phuocantd commented Jul 20, 2022

@blackbing
error when build android

* What went wrong:
Execution failed for task ':xmartlabs_react-native-line:compileDebugKotlin'.
> Compilation error. See log for more details

how to work on Android and iOS
I using react 18.2.0 and react-native 0.69.1

@blackbing
Copy link
Contributor Author

@blackbing error when build android

* What went wrong:
Execution failed for task ':xmartlabs_react-native-line:compileDebugKotlin'.
> Compilation error. See log for more details

how to work on Android and iOS I using react 18.2.0 and react-native 0.69.1

Do you install our fork repo?

yarn add verybuy/react-native-line#8dcc99d

@phuocantd
Copy link

phuocantd commented Jul 20, 2022

@blackbing I install
yarn add @xmartlabs/react-native-line@VeryBuy/react-native-line#feat/upgrade-sdk

@blackbing
Copy link
Contributor Author

@phuocantd
Copy link

Have you done Android setup? https://github.com/VeryBuy/react-native-line/tree/feat/upgrade-sdk#android-setup

@blackbing work on iOS when downgrade react-native version 0.67.2 but Android I setup follow you but open popup then display error

@phuocantd
Copy link

@blackbing you can check in this repo
https://github.com/phuocantd/RNLine

@phuocantd
Copy link

phuocantd commented Jul 20, 2022

@blackbing I found the cause, because it doesn't match the package name. I hope you will update for react native version 0.69 soon

@blackbing
Copy link
Contributor Author

I see. Our project use react-native@0.67. when we upgrade to 0.69 above, I will take a look the problem. I think it might do some migrate task like this.
https://reactnative.dev/blog/2022/06/16/resources-migrating-your-react-native-library-to-the-new-architecture

@phuocantd
Copy link

from ver0.68 file AppDelegate.m convert to AppDelegate.mm

@VanDinh18
Copy link

@phuocantd i have error on Android "xmartlabs_react-native-line:compileDebugKotlin". How to fix it

@phuocantd
Copy link

@phuocantd i have error on Android "xmartlabs_react-native-line:compileDebugKotlin". How to fix it

what's version react native you use?

Copy link

@emibotti emibotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for contributing!
Sorry for the very late response, the idea is to go back to maintaining the repo.
I suppose you won't be doing any of these changes because of how much time has passed since you opened it.
I will merge these changes to a new branch and work on it to merge it to master as soon as possible and do a release to make it available to all the devs.
Thank you again!! Your fork was able to help so many developers in the meantime 🙏

Comment on lines +146 to +151
...
dependencies {
...
implementation 'com.linecorp.linesdk:linesdk:5.7.0' // <- add this line
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you for contributing! The idea is that the final user doesn't need to implement LINE directly, the library takes care of it. So I would remove this block

Suggested change
...
dependencies {
...
implementation 'com.linecorp.linesdk:linesdk:5.7.0' // <- add this line
}
}

Comment on lines +140 to +145
android {
// Enable Java 1.8 support.
compileOptions { // <- add this block if didn't setup
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice catch! Thank you!!
Anyway, we encourage the users to read the line documentation, since it will be always up-to-date.

@emibotti emibotti changed the base branch from master to feature/upgrade-native-sdks February 28, 2023 18:20
@emibotti emibotti merged commit 8774714 into xmartlabs:feature/upgrade-native-sdks Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants