Bugfix/android kotlin #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoache1
requested review from
emibotti,
franbe7,
Joaguirrem,
MarcoF09,
mirland and
santiagofm
…d Android, also update the contributorssss :P
nicoache1
force-pushed
the
bugfix/android_kotlin
branch
from
329a854 to
7d18c20
Compare
mirland
reviewed
Jul 6, 2020
| @@ -56,8 +56,10 @@ class RNLine(reactContext: ReactApplicationContext) : ReactContextBaseJavaModule | |||
|
|
|||
| @ReactMethod | |||
| fun login(args: ReadableMap, promise: Promise) { | |||
| println(args) | |||
There was a problem hiding this comment.
shouldn't you do it only in debug mode or something like that?
emibotti
approved these changes
Jul 6, 2020
| return [LineLogin application:app open:url options:options]; | ||
| } | ||
|
|
||
| - (BOOL)application:(UIApplication *)application continueUserActivity:(NSUserActivity *)userActivity restorationHandler:(void (^)(NSArray<id<UIUserActivityRestoring>> * _Nullable))restorationHandler |
There was a problem hiding this comment.
I would add these two to Swift section too.
| @@ -92,6 +108,9 @@ Don't forget to add `application` function, as line's instructions indicate. | |||
| <string name="line_channel_id" translatable="false">Your channel id here</string> | |||
There was a problem hiding this comment.
Can you please change this line :
https://developers.line.me/en/docs/line-login/android/integrate-line-login/ in Line's Android integration guide to:
https://developers.line.biz/en/docs/android-sdk/integrate-line-login/
| @@ -23,7 +23,7 @@ import com.linecorp.linesdk.LineProfile | |||
| enum class LoginArguments(val key: String) { | |||
| SCOPES("scopes"), | |||
| ONLY_WEB_LOGIN("onlyWebLogin"), | |||
| BOT_PROMPT("onlyWebLogin") | |||
| BOT_PROMPT("botPrompt") | |||
| @@ -233,7 +232,7 @@ class RNLine(reactContext: ReactApplicationContext) : ReactContextBaseJavaModule | |||
| ) | |||
| ) | |||
|
|
|||
| private fun parseVerifyAccessToken(verifyAccessToken: LineCredential): WritableMap = Arguments.makeNativeMap( | |||
| private fun parseVerifyAccessToken( verifyAccessToken: LineCredential): WritableMap = Arguments.makeNativeMap( | |||
There was a problem hiding this comment.
Suggested change
| private fun parseVerifyAccessToken( verifyAccessToken: LineCredential): WritableMap = Arguments.makeNativeMap( | |
| private fun parseVerifyAccessToken(verifyAccessToken: LineCredential): WritableMap = Arguments.makeNativeMap( |
You left a whitespace there 😛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix; Android issue with onlyWebLogin
🔄 Type of change:
✏️ Description:
Solve issue in android with onlyWebLogin prop, also add some improvements and add support for email and lineIdToken