-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor README #5
Conversation
# Conflicts: # src/utils/types/knownIds.ts
…into docs/typedoc
@bolasblack reviewed and merged changes you sent to our repo. We still have some basic concerns: the generated docs format displays some non-existing or not-accessible objects on the left column (lib hierarchy sections).
Seen that, I think we should try to remove definitions in entrypoint and try to go with If you want merge this one and we then can change the typedoc issue tomorrow. capture 1> import{ bitcoinHelpers } from '@xlink-network/xlink-sdk';
<repl>.ts:4:9 - error TS2305: Module '"@xlink-network/xlink-sdk"' has no exported member 'bitcoinHelpers'.
4 import{ bitcoinHelpers } from '@xlink-network/xlink-sdk';
~~~~~~~~~~~~~~ capture 2
|
Hi @tenuki , that's a good question, if you can install this package in any other project, you can try like this: if users are using the legacy version of nodejs, they can write
Yes, but I have no better idea how to deal with it, if we need to export multiple endpoints in the future. And I guess users would understand it (since nodejs will respect index.js as the default entrypoint of a module) |
* add typedoc comments * fix merge error * update dev-dependencies to include typedoc * update package json * add errors to typedoc * add use cases and missing function to typedoc * README refactor and link to typedoc for documentation * refactor README * fix link to typedoc * typedoc config was modified * fixed imports * fix link and some formating --------- Co-authored-by: david weil <david.weil@endlesstruction.com.ar> Co-authored-by: david weil <tenuki@gmail.com>
This PR includes minor fixes to the readme.
Also modified typedoc in package.json.