Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove counter to keep aligned with early return in fast path #859

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

CrystalAnalyst
Copy link
Contributor

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    Update testing logic to keep aligned with early return in fast path.
    Since we can return early in fast path when the number of conlicts is so large that we cannot reach SuperQuorum.
    So we DO NOT NEED to force all the 5 servers to handle the propose.
    related issue : [Bug]: test_unary_propose_fast_path_fallback_slow_path will randomly failed  #840

  • what changes does this pull request make?
    Remove the counter, and the rest part works fine (Successfully fallback to slow path) .

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@mergify mergify bot requested a review from a team June 18, 2024 04:33
@CrystalAnalyst CrystalAnalyst changed the title fix : remove counter to keep aligned with early return in fast path fix: remove counter to keep aligned with early return in fast path Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.72%. Comparing base (e35b35a) to head (97aa29d).
Report is 121 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
+ Coverage   75.55%   75.72%   +0.16%     
==========================================
  Files         180      187       +7     
  Lines       26938    27822     +884     
  Branches    26938    27822     +884     
==========================================
+ Hits        20353    21067     +714     
- Misses       5366     5465      +99     
- Partials     1219     1290      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zhiyuan <kevin91cooland@gmail.com>
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot requested a review from a team June 18, 2024 06:12
@mergify mergify bot merged commit e040831 into xline-kv:master Jun 18, 2024
14 checks passed
@mergify mergify bot requested a review from a team June 18, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: test_unary_propose_fast_path_fallback_slow_path will randomly failed
3 participants