-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Refactor the shutdown channel #174
Comments
Phoenix500526
added a commit
to Phoenix500526/Xline
that referenced
this issue
Feb 9, 2023
Phoenix500526
added a commit
to Phoenix500526/Xline
that referenced
this issue
Feb 9, 2023
Phoenix500526
added a commit
to Phoenix500526/Xline
that referenced
this issue
Feb 9, 2023
Merged
Phoenix500526
added a commit
to Phoenix500526/Xline
that referenced
this issue
Feb 9, 2023
Phoenix500526
added a commit
to Phoenix500526/Xline
that referenced
this issue
Feb 10, 2023
Phoenix500526
added a commit
to Phoenix500526/Xline
that referenced
this issue
Feb 10, 2023
Phoenix500526
added a commit
to Phoenix500526/Xline
that referenced
this issue
Feb 10, 2023
Phoenix500526
added a commit
to Phoenix500526/Xline
that referenced
this issue
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, our curp server will abort all the background tasks via a
Shutdown
instance. When aProtocol
instance is dropped, it will send a message to notify a background task to abort other tasks. Some relevant codes are shown below:However, we don't need to record this
shutdown
bool variable, since this shutdown channel will only be notified once. Thus, we can use an event listener to replace theShutdown
struct.The text was updated successfully, but these errors were encountered: