Conversation
* able to modify session retry_times (disable the adapter when retries=0) - Temporarily modify the retry count in the adapter by injecting the request count into the request headers. * add unit_test for custom session retries * add comment * fix bug occurs in TimeoutHTTPAdapter when timeout=None * handle ValueError caused by int(_retry) - simplified some code in SwanSession * Add retries parameter to client HTTP methods Refactored Client to use SessionWithRetry and updated HTTP method signatures to accept an optional retries parameter. Overrode method signatures in SessionWithRetry to support retries and updated batch uploader to explicitly set retries to 0 for metric tracing. This improves control over request retry behavior. * Validate retry count in TimeoutHTTPAdapter Added a check to ensure the retry count is a non-negative integer in TimeoutHTTPAdapter. Updated error messages for clarity and added a unit test to verify ValueError is raised for invalid retry values. --------- Co-authored-by: Kang Li <cunykang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )