Skip to content

Conversation

@yuancu
Copy link

@yuancu yuancu commented Mar 6, 2025

Description

Implement math UDFs, their unit tests, and their integration tests.

Integration Test Coverage

Functions Covered by Spark IT Covered by IT
abs Y Y
acos   Y
asin   Y
atan   Y
atan2   Y
cbrt   Y
ceiling Y Y
conv   Y
cos   Y
cot   Y
crc32   Y
degrees   Y
e   Y
exp   Y
floor Y Y (Modified)
ln Y Y
log   Y
log2   Y
log10   Y
mod Y Y
pi   Y
pow Y Y
radians   Y
rand   Y
round   Y
sign   Y
sin   Y
sqrt Y Y

The integration tests covered by Spark are copied to this IT (Apart from floor). The rest is implemented by ourselves.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

yuancu added 3 commits March 5, 2025 14:22
- Additionally implement user-defined ConvFunction

Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
@xinyual xinyual merged commit 66859e4 into xinyual:addMathUDF Mar 6, 2025
3 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants