Skip to content

Add IT for Null & Malform Inputs #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xinyual merged 9 commits into from
Mar 26, 2025
Merged

Add IT for Null & Malform Inputs #16

xinyual merged 9 commits into from
Mar 26, 2025

Conversation

@yuancu
Copy link

@yuancu yuancu commented Mar 25, 2025 •
edited
Loading

When WIP is removed from title, the PR is ready for merging.

NULL Input validation:

  • addtime
  • adddate
  • now
  • date_sub
  • date_add
  • date
  • hour
  • hour_of_day
  • month_of_year
  • month
  • curtime
  • curdate
  • current_date
  • current_time
  • current_timestamp
  • date_format
  • datediff
  • dayofweek
  • day_of_week
  • day
  • dayofyear
  • day_of_year
  • dayofmonth
  • day_of_month
  • dayname
  • EARLIEST
  • LATEST
  • RELATIVE_TIMESTAMP
  • extract
  • from_unixtime
  • last_day
  • localtimestamp
  • localtime
  • makedate
  • minute_of_day
  • minute_of_hour
  • minute
  • monthname
  • quarter
  • timestamp
  • second
  • second_of_minute
  • convert_tz
  • datetime
  • from_days
  • get_format
  • maketime
  • microsecond
  • period_diff
  • period_add
  • str_to_date
  • subtime
  • subdate
  • sysdate
  • time
  • time_format
  • time_to_sec
  • timediff
  • sec_to_time
  • timestampadd
  • timestampdiff
  • to_days
  • to_seconds
  • unix_timestamp
  • utc_date
  • utc_time
  • utc_timestamp
  • week & week_of_year
  • weekday
  • year
  • yearweek

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

yuancu added 7 commits March 25, 2025 16:45
@yuancu
Add ITs for ADDTIME, ADDDATE, DATESUB, DATEADD, DATE
b79b3d9 
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
@yuancu
Parse date / time exclusively for YEAR, QUARTER, MONTH, DAY, HOUR, MI…
04064d6 
…NUTE, SECOND, etc

- it won't parse a time string where a date string is required

Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
@yuancu
Add date time null input ITs
59b4817 
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
@yuancu
Make all udf return types nullable
86f1538 
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
@yuancu
Remove nullable argument in getReturnTypeForAddOrSubDate
a9dc42b 
since it's no longer necessary

Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
@yuancu
Merge xinyual/cleanDateTime to cleanDateTime
dd803e0 
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
@yuancu
Fix date time null returns & Add null ITs
c0b0c11 
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
@yuancu yuancu changed the title WIP: Add IT for Null & Malform Inputs Add IT for Null & Malform Inputs Mar 26, 2025
@yuancu yuancu marked this pull request as ready for review March 26, 2025 08:41
yuancu added 2 commits March 26, 2025 17:09
@yuancu
Allow timestamp string where date or time string is required
59a7b74 
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
@yuancu
Remove redundant nullify of return types
c50dbc3 
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
@xinyual xinyual merged commit 16db26e into xinyual:cleanDateTime Mar 26, 2025
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yuancu @xinyual