Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 269] Index prop necessary for dynamic input textfield. #280

Merged
merged 3 commits into from
Jan 5, 2017
Merged

[Issue 269] Index prop necessary for dynamic input textfield. #280

merged 3 commits into from
Jan 5, 2017

Conversation

Freydal
Copy link
Contributor

@Freydal Freydal commented Dec 27, 2016

Adding a static fix for the issue. Could update with a dynamic solution if preferred.

@Crash--
Copy link
Collaborator

Crash-- commented Dec 28, 2016

Just read the issue #269. I think a dynamic solution can be better. At least everyone will be able to add props they want. Something like ...additionalInputProps is great :)

@Freydal
Copy link
Contributor Author

Freydal commented Dec 28, 2016

Sounds great. I wasn't sure how the more advanced change would go over since I didn't get much feedback with the issue. I'll take care of this later today.

@Freydal
Copy link
Contributor Author

Freydal commented Dec 28, 2016

Alright, let me know what you think. I can update the readme if you feel its appropriate.

@Crash--
Copy link
Collaborator

Crash-- commented Dec 29, 2016

Yep, can you update the Readme also please? Thank you

@Freydal
Copy link
Contributor Author

Freydal commented Jan 4, 2017

Sorry for the delays but the Holidays had me a little distracted. I didn't see much relevance on the readme page aside for the link to xinthink. I believe my changes will reflect the updated information appropriately.

@Crash-- Crash-- merged commit e472b89 into xinthink:master Jan 5, 2017
@Crash--
Copy link
Collaborator

Crash-- commented Jan 5, 2017

thank you for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants