qt: Expose branding color #670
Open
+210
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note this breaks the FreeBSD CI because the forward declaration is by class rather than struct. I'd pass this values as QStringView rather than QString when possible (not that it matters much, most of these APIs will be unused). |
ximion
requested changes
Oct 6, 2024
| #include <QSharedDataPointer> | ||
| #include "appstreamqt_export.h" | ||
|
|
||
| class _AsBranding; |
There was a problem hiding this comment.
This should be struct, shouldn't it?
| @@ -0,0 +1,102 @@ | |||
| // SPDX-FileCopyrightText: 2024 Carl Schwan <carl@carlschwan.eu> | |||
| // SPDX-License-Identifier: LGPL-2.1-or-later | |||
There was a problem hiding this comment.
Can you use the full copyright please, like in all other files? I do like the SPDX strings, but I think it will be easier to convert everything all at once at a future point, rather than having one outlier file.
| { | ||
| } | ||
|
|
||
| Branding::Branding(_AsBranding *devp) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.