Skip to content

use close event callback to fix issue 92 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2018
Merged

use close event callback to fix issue 92 #93

merged 1 commit into from
Aug 30, 2018

Conversation

xiegeo
Copy link
Owner

@xiegeo xiegeo commented Aug 29, 2018

@xiegeo xiegeo requested a review from anishkny August 29, 2018 23:15
@xiegeo xiegeo mentioned this pull request Aug 29, 2018
Closed
anishkny
anishkny approved these changes Aug 30, 2018
View reviewed changes
Copy link
Collaborator

@anishkny anishkny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anishkny anishkny merged commit 11a8f9a into master Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anishkny anishkny anishkny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiegeo @anishkny