driver/serial: Echo only determined by ECHO flag with termios enabled

Fix a bug that can not disable echo even if termios is enabled. Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
xiaoxiang781216 · Mar 3, 2023 · 44857ab · 44857ab
1 parent 392eebf
commit 44857ab
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c
@@ -890,9 +890,11 @@ static ssize_t uart_read(FAR struct file *filep,
           *buffer++ = ch;
           recvd++;
 
-          if (dev->isconsole
+          if (
 #ifdef CONFIG_SERIAL_TERMIOS
-              || (dev->tc_iflag & ECHO)
+              dev->tc_iflag & ECHO
+#else
+              dev->isconsole
 #endif
              )
             {