Xiaotong sun patch 2 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idear1203
reviewed
Dec 23, 2019
Contributor
idear1203
left a comment
idear1203
left a comment
There was a problem hiding this comment.
Leave a few comments below
Contributor
|
Nice to remove spaces in the file name |
Co-Authored-By: Dongwei Wang <bean0idear@163.com>
Contributor
|
Try using more meaningful PR title and description. The title should briefly introduce what the PR aims to do while the description should provide more details. Reference here for example. |
idear1203
reviewed
Dec 23, 2019
Contributor
|
Familiar yourself with Git commands such as |
idear1203
reviewed
Dec 24, 2019
idear1203
reviewed
Dec 24, 2019
idear1203
reviewed
Dec 24, 2019
idear1203
reviewed
Dec 24, 2019
idear1203
reviewed
Dec 24, 2019
Contributor
|
Try using more meaningful PR title and description. The title should briefly introduce what the PR aims to do while the description should provide more details. Reference here for example. |
idear1203
reviewed
Dec 24, 2019
idear1203
reviewed
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.