Add display names feature #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Parser/Parser.php
Outdated
| /** @var Users $users */ | ||
| protected $users; | ||
|
|
||
| public function __construct(Config $config, ResourceManager $resourceManager, MetadataDriver $metadata, Users $users) |
There was a problem hiding this comment.
If BC is being observed, this is a break.
There was a problem hiding this comment.
Oh! Good point!
Thanks for checking @GawainLynch 👍
|
Moved mandatory constructor param to public NB: Good resource on BC: https://symfony.com/doc/current/contributing/code/bc.html |
xiaohutai
force-pushed
the
feature/add-displaynames
branch
from
d3f079b to
0de2c89
Compare
xiaohutai
force-pushed
the
feature/add-displaynames
branch
from
0de2c89 to
ec57a3b
Compare
|
Hey @xiaohutai ! Are we all good here ? Is this merge-able and bump-able to v4.0 ? 😃 |
|
@HorlogeSkynet Watch out for |
|
Thanks for all, see you 👋🏻 |
|
Wow, such rude boys we are... Just wanted to tell you this DID PERFECTLY THE JOB. Thanks again. Bye 👋 |
|
😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires opt-in via
enabledisplaynamesin configI'm not 100% about adding a whole service for one feature.
Ideally this key, value is added before parse?
Fixes #84