Skip to content

Commit

Permalink
config-linux: Explicitly allow symlinks for providing devices
Browse files Browse the repository at this point in the history
I'd rather address runtime compliance by breaking this down into
explicit checks based on POSIX stat(3) calls.  But with that approach
rejected [1], mentioning symlinks here helps motivate runtime-tools'
choice of os.Stat [2,3] (which follows symlinks) vs. os.Lstat (which
does not [4]).

[1]: opencontainers#829 (comment)
[2]: https://github.com/opencontainers/runtime-tools/blob/f5c82b3918bdfc3ed4b594dcfab4d1554beaf992/cmd/runtimetest/main.go#L319
[3]: https://golang.org/pkg/os/#Stat
[4]: https://golang.org/pkg/os/#Lstat

Signed-off-by: W. Trevor King <wking@tremily.us>
  • Loading branch information
wking committed Jun 6, 2017
1 parent e95b4f8 commit 04187ec
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion config-linux.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ Note that the number of mapping entries MAY be limited by the [kernel][user-name
## <a name="configLinuxDevices" />Devices

**`devices`** (array of objects, OPTIONAL) lists devices that MUST be available in the container.
The runtime MAY supply them however it likes (with [`mknod`][mknod.2], by bind mounting from the runtime mount namespace, etc.).
The runtime MAY supply them however it likes (with [`mknod`][mknod.2], by bind mounting from the runtime mount namespace, using symlinks, etc.).

Each entry has the following structure:

Expand Down

0 comments on commit 04187ec

Please sign in to comment.