fix dag retries (argoproj#1221)

xianlubird · Feb 20, 2019 · e817cdf · e817cdf
1 parent 7c1f232
commit e817cdf
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/workflow/controller/dag.go b/workflow/controller/dag.go
@@ -79,7 +79,9 @@ func (d *dagContext) assessDAGPhase(targetTasks []string, nodes map[string]wfv1.
 			unsuccessfulPhase = node.Phase
 		}
 		if node.Type == wfv1.NodeTypeRetry {
-			if hasMoreRetries(&node, d.wf) {
+			if node.Successful() {
+				retriesExhausted = false
+			} else if hasMoreRetries(&node, d.wf) {
 				retriesExhausted = false
 			}
 		}