Adds (the rest) of the murder mystery weapon skins #808
Conversation
📝 WalkthroughWalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Player
participant Game
participant MurderMystery
Player->>Game: Start Game
Game->>MurderMystery: Check Game State
MurderMystery->>MurderMystery: Identify Items
MurderMystery->>Game: Update Player Roles
Game->>Player: Notify Roles
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
Tip 🧪 Early access (models): enabledWe are currently testing new code review model(s) that may lead to higher noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
📒 Files selected for processing (1)
- src/main/java/keystrokesmod/module/impl/minigames/MurderMystery.java (1 hunks)
🔇 Additional comments (1)
src/main/java/keystrokesmod/module/impl/minigames/MurderMystery.java (1)
41-66: Verify unusual weapon choicesSome added items seem unusual for murder weapons (e.g., boat, cookie, book). While this might be intentional for gameplay variety, please confirm if these items are actually used as weapons in the Murder Mystery game mode.
| Items.blaze_rod, | ||
| Items.stone_shovel, | ||
| Items.diamond_shovel, | ||
| Items.quartz, | ||
| Items.pumpkin_pie, | ||
| Items.golden_pickaxe, | ||
| Items.apple, | ||
| Items.name_tag, | ||
| Items.carrot_on_a_stick, | ||
| Items.bone, | ||
| Items.carrot, | ||
| Items.golden_carrot, | ||
| Items.cookie, | ||
| Items.diamond_axe, | ||
| Items.cooked_beef, | ||
| Items.netherbrick, | ||
| Items.cooked_chicken, | ||
| Items.record_blocks, | ||
| Items.golden_hoe, | ||
| Items.diamond_hoe, | ||
| Items.shears, | ||
| Items.cooked_fish, | ||
| Items.boat, | ||
| Items.speckled_melon, | ||
| Items.book, | ||
| Items.prismarine_shard, | ||
| Item.getItemById(19), | ||
| Item.getItemById(32), | ||
| Item.getItemById(175), | ||
| Item.getItemById(6) |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Approved: Successfully adds remaining weapon skins
The changes successfully implement the PR objective by adding the remaining weapon skins that can be held by the murderer. This enhancement will improve the game's ability to identify murderers based on their held items.
However, consider adding a comment explaining the criteria for selecting these items as murder weapons, which would help future maintainers understand the choices.
private static final Set<Item> MURDER_ITEMS = new HashSet<>(Arrays.asList(
+ // Standard weapons
Items.wooden_sword,
Items.stone_sword,
// ... other existing items ...
+ // Additional murder mystery weapon skins
Items.blaze_rod,
// ... other new items ...
));Committable suggestion was skipped due to low confidence.
|
please fork from dev branch and make pull request to dev branch |
Description
all of the weapons you can hold as murderer in murder mystery will mark player as a murderer
Summary by CodeRabbit