-
-
Notifications
You must be signed in to change notification settings - Fork 100
Unify attachment api #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP to merge all attachment to only one Email method called Attach and use the struct File to set the attachment information. For #33
Finished Unify all attachments in method Attach and using File struct
jlinnosa
reviewed
Apr 28, 2021
jlinnosa
reviewed
Apr 28, 2021
jlinnosa
reviewed
Apr 28, 2021
Instead to do a breaking change, maintain the old way until v3. Also add some TODOs
This PR is completed. I will left opened for reviews until Cinco de Mayo |
What I meant by the "shim" was a simple layer to translate old API into new.
This way you don't have to have duplicate implementations and the old tests should pass. |
In deprecated attach functions, use the new Attach api. Also, maintain the same behavior in AddAttachment and AddInline checking the len of name parameter.
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge all attachment to only one
Email
method calledAttach
and use the structFile
to set the attachment information.Fix #33