-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stats features #518
Add stats features #518
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 92.03% 92.05% +0.01%
==========================================
Files 60 60
Lines 4370 4378 +8
==========================================
+ Hits 4022 4030 +8
Misses 348 348 ☔ View full report in Codecov by Sentry. |
Looks good thanks Nich! Do you think there's a way to use numpy's argmin/max to get all indices rather than just the first? Would we want that? |
That could be good, but unfortunately numpy does the same thing (returns the first max/min). I can look more into it though! |
I found this: https://stackoverflow.com/questions/25762332/how-to-get-all-the-keys-with-the-same-highest-value, but I'm not sure if we want to return an iterate. Let me know what you think! |
Ah true, my bad.
Yea I'm not sure either honestly. Maybe let's keep it as it is for now (it's pretty standard to return just the first occurrence), and see later? You documented it so it should be okay for now. Ultimately, say we're looking for the nodes that have minimum degree. We might want to get all of them, not just the first. If we don't implement this by default, would there be a way to do it by hand by iterating for the user? And if we return all of them by default, we should check for format consistency with other stats to avoid potential problems. |
I think that we can accomplish this in two ways: (1) add the ability to |
Partially addresses #514.