Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor multilayer drawing function and add headers to convert module #434

Merged
merged 11 commits into from
Aug 3, 2023

Conversation

nwlandry
Copy link
Collaborator

This adds the ability for users to specify the colors/sizes of every node/edge in the multilayer drawing function.

@nwlandry
Copy link
Collaborator Author

Happy for any feedback @thomasrobiglio!!

@leotrs leotrs changed the title initial commit Let users to specify the colors/sizes of every node/edge in the multilayer drawing function Jul 27, 2023
* refact: draw module

* style: black and isort
@thomasrobiglio
Copy link
Collaborator

@nwlandry let me know if this is still a draft or you want me to review it (it looks like the function is ready we just need to twitch the tests)... I tried it very quickly today and it seems very nice and much more coherent with the rest of the drawing functions of XGI than my initial attempt 😄, thank you!

@nwlandry
Copy link
Collaborator Author

Hi @thomasrobiglio, yes sorry about this - let me draft it and undraft when I am done updating the docs, tests, etc. I had a great foundation to work from, so thanks :)

@nwlandry nwlandry marked this pull request as draft July 28, 2023 15:46
@nwlandry nwlandry changed the title Let users to specify the colors/sizes of every node/edge in the multilayer drawing function Allow users to specify the colors/sizes of every node/edge in the multilayer drawing function Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch coverage: 93.57% and no project coverage change.

Comparison is base (cbaec09) 90.97% compared to head (f9c9cc0) 90.97%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #434   +/-   ##
=======================================
  Coverage   90.97%   90.97%           
=======================================
  Files          58       59    +1     
  Lines        4088     4100   +12     
=======================================
+ Hits         3719     3730   +11     
- Misses        369      370    +1     
Files Changed Coverage Δ
xgi/convert/bipartite_edges.py 44.44% <ø> (ø)
xgi/convert/bipartite_graph.py 100.00% <ø> (ø)
xgi/convert/graph.py 100.00% <ø> (ø)
xgi/convert/higher_order_network.py 95.19% <ø> (ø)
xgi/convert/hyperedges.py 100.00% <ø> (ø)
xgi/convert/hypergraph_dict.py 95.45% <ø> (ø)
xgi/convert/incidence.py 76.92% <ø> (ø)
xgi/convert/line_graph.py 95.00% <ø> (-5.00%) ⬇️
xgi/convert/pandas.py 100.00% <ø> (ø)
xgi/convert/simplex.py 100.00% <ø> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nwlandry nwlandry marked this pull request as ready for review July 30, 2023 19:51
Copy link
Collaborator

@thomasrobiglio thomasrobiglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice @nwlandry thank you!

I would suggest to rename the PR name in order to mark also the reorganisation of the draw.py module with the creation of draw_utils.py

Random thought: how do we feel allowing also for the personalisation of the planes colors here also?

xgi/drawing/draw_utils.py Show resolved Hide resolved
@nwlandry nwlandry changed the title Allow users to specify the colors/sizes of every node/edge in the multilayer drawing function Refactor multilayer drawing function and add headers to convert module Aug 3, 2023
@nwlandry
Copy link
Collaborator Author

nwlandry commented Aug 3, 2023

I added a plane_color option with the default as grey. Because I rebased, it looks like I reorganized the drawing module, but that is already on the main branch. Thanks for the review!!

@nwlandry nwlandry merged commit 52e6aac into main Aug 3, 2023
18 checks passed
@nwlandry nwlandry deleted the multilayer-draw branch August 3, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants