-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added weights option to to_line_graph function. #427
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
- Coverage 90.95% 90.94% -0.02%
==========================================
Files 57 59 +2
Lines 4024 4085 +61
==========================================
+ Hits 3660 3715 +55
- Misses 364 370 +6
☔ View full report in Codecov by Sentry. |
Does codecov want me to add some tests? I don't understand the failed check. |
Hi @tlarock - yep, it will trigger a warning if the unit test coverage goes down by more than 0.1%. If you're able to add a few tests for the new functionality, that's great, but otherwise we can deal with it later. Thanks for the PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, @tlarock! Looks good! If everything is good from your end, I'll go ahead and merge it. One thing that I would be interested in getting you opinion on is where a breadth-first search would be more efficient down the road, but I think that's not a high priority right now.
Good to be merged from my end @nwlandry! Not sure off the top of my head where BFS could be more efficient but happy to discuss. |
Thanks Tim!! |
Addresses discussion in abandoned PR #425, now integrated with new
convert
module.Adds a single
weights
parameter toto_line_graph
with optionsNone
(no weights),'absolute'
(size of intersection between hyperedges), and'normalized'
(size of intersection divided by size of smaller). Raises anXGIError
if a bad choice is given.