Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: added basic for layouts #293

Merged
merged 2 commits into from
Mar 14, 2023
Merged

tests: added basic for layouts #293

merged 2 commits into from
Mar 14, 2023

Conversation

maximelucas
Copy link
Collaborator

@maximelucas maximelucas commented Mar 14, 2023

  • added initial tests for layout functions
  • added seed argument for layout functions that did not have it

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.49 🎉

Comparison is base (c72af43) 82.01% compared to head (a26575d) 83.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
+ Coverage   82.01%   83.50%   +1.49%     
==========================================
  Files          35       35              
  Lines        2691     2698       +7     
==========================================
+ Hits         2207     2253      +46     
+ Misses        484      445      -39     
Impacted Files Coverage Δ
xgi/drawing/layout.py 78.26% <100.00%> (+65.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@nwlandry nwlandry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much! Having the seed arg will make life SO much easier.

@maximelucas maximelucas merged commit e37c299 into main Mar 14, 2023
@maximelucas maximelucas deleted the tests-drawing branch March 14, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants