Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added uniform generators #286

Merged
merged 10 commits into from
Mar 14, 2023
Merged

added uniform generators #286

merged 10 commits into from
Mar 14, 2023

Conversation

nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented Mar 6, 2023

Added

  • hypergraph SBM method
  • hypergraph planted partition method
  • hypergraph Erdős–Rényi model

@maximelucas
Copy link
Collaborator

Looks nice, thanks Nich! I was thinking of adding a uniform ER function for a long time myself.

Maybe add a basic tests and a black pass?
Would also be better if someone else could have another look at the algos themselves.

nwlandry and others added 4 commits March 13, 2023 10:34
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@d032a3b). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage        ?   79.69%           
=======================================
  Files           ?       35           
  Lines           ?     2709           
  Branches        ?        0           
=======================================
  Hits            ?     2159           
  Misses          ?      550           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nwlandry
Copy link
Collaborator Author

All your comments should be addressed I believe.

@maximelucas
Copy link
Collaborator

Nice!!

@maximelucas
Copy link
Collaborator

(I think in the future we might want to make the naming of all our generators more consistent. Older generators did not use acronyms. Some use "hypergraph" in front, others at the end. Do we need to mention "hypergraph" in all of their names?)

@nwlandry
Copy link
Collaborator Author

I agree! I will commit this and add your suggestion as an issue.

@nwlandry nwlandry merged commit d6824c8 into main Mar 14, 2023
@nwlandry nwlandry deleted the uniform-sbm branch March 14, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants