-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added uniform generators #286
Conversation
Looks nice, thanks Nich! I was thinking of adding a uniform ER function for a long time myself. Maybe add a basic tests and a black pass? |
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
=======================================
Coverage ? 79.69%
=======================================
Files ? 35
Lines ? 2709
Branches ? 0
=======================================
Hits ? 2159
Misses ? 550
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
All your comments should be addressed I believe. |
Nice!! |
(I think in the future we might want to make the naming of all our generators more consistent. Older generators did not use acronyms. Some use "hypergraph" in front, others at the end. Do we need to mention "hypergraph" in all of their names?) |
I agree! I will commit this and add your suggestion as an issue. |
Added