-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non recursive add simplex #247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwlandry
reviewed
Dec 8, 2022
nwlandry
reviewed
Dec 8, 2022
…clarity and to avoid redundancy
|
I did a few tests of my own, adding/removing simplices, etc. and everything works flawlessly! This is great work!! |
nwlandry
approved these changes
Dec 9, 2022
This was referenced Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_simplices_from
so that is is non-recursive.With the rewrite, we first add all input simplices, store all faces, and add the faces add the end. It used to add each input simplex with its faces, so this changes the order in which simplices are added. This new order solves #244
Notes:
set
of faces. This seems to sometimes randomly change the order of simplices.test_boundary_matrix
. I think it's cause by the change in order which causes simplices to have different IDs. Might need @Marconurisso to check on this one.remove_simplex_ids_from
does not enforce removing subfaces #85 is still a problem