Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor feats #192

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Minor feats #192

merged 2 commits into from
Oct 14, 2022

Conversation

maximelucas
Copy link
Collaborator

Implements #183 and #184.

@leotrs
Copy link
Collaborator

leotrs commented Oct 5, 2022

@nwlandry recently we discussed making num_edges a method instead of a property - do you remember what was the context of that? If we ever get to that, then we might as well just add the order parameter to num_edges instead of adding a second method like on this PR.

@nwlandry
Copy link
Collaborator

nwlandry commented Oct 7, 2022

I believe that this was in the context of simplicial complexes where there are different notions of number of simplices (i.e., is it all the subfaces as well, or just maximal simplices?)

@maximelucas maximelucas merged commit 4a7befc into main Oct 14, 2022
@maximelucas maximelucas deleted the minor_feats branch October 14, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants