Skip to content

Commit

Permalink
test: Cypress - Flaky Fix (appsmithorg#25070)
Browse files Browse the repository at this point in the history
## Description

**Fixed below flaky tests**

- MongoDBShoppingCart_spec.ts
- FirstTimeUserOnboarding_spec.js

## Type of change

- Flaky test fix

## How Has This Been Tested?
- Cypress test runs

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
  • Loading branch information
Vijetha-Kaja authored Jul 4, 2023
1 parent 6488eff commit c079b37
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ describe("Shopping cart App", function () {
agHelper.UpdateInput(appPage.bookquantity, 2, true);
agHelper.GetNClick(appPage.addButton, 0, true);
assertHelper.AssertNetworkStatus("@postExecute");
agHelper.GetNClick(appPage.bookname);
agHelper.UpdateInput(appPage.bookname, "A man called ove", true);
agHelper.UpdateInput(appPage.bookgenre, "Fiction", true);
agHelper.UpdateInput(appPage.bookprice, 100, true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,12 @@ describe("FirstTimeUserOnboarding", function () {
agHelper.AssertElementVisible(OnboardingLocator.dropTarget);
entityExplorer.DragDropWidgetNVerify(draggableWidgets.TEXT);
agHelper.RefreshPage(true, "getPage");
agHelper.AssertElementEnabledDisabled(
debuggerHelper.locators._helpButton,
0,
false,
);
agHelper.Sleep(500);
agHelper.GetNClick(debuggerHelper.locators._helpButton);
agHelper.AssertElementVisible(OnboardingLocator.introModal);
agHelper.AssertElementVisible(OnboardingLocator.textWidgetName);
Expand All @@ -203,7 +209,13 @@ describe("FirstTimeUserOnboarding", function () {
agHelper.GetNClick(OnboardingLocator.introModalCloseBtn);
homePage.NavigateToHome();
homePage.CreateNewApplication(false);
agHelper.AssertElementExist(locators._dropHere);
agHelper.AssertElementVisible(locators._dropHere);
agHelper.AssertElementEnabledDisabled(
debuggerHelper.locators._helpButton,
0,
false,
);
agHelper.Sleep(500);
agHelper.GetNClick(debuggerHelper.locators._helpButton);
agHelper.AssertElementVisible(OnboardingLocator.checklistDatasourceBtn);
});
Expand All @@ -216,6 +228,12 @@ describe("FirstTimeUserOnboarding", function () {
homePage.CreateNewApplication(false);

agHelper.AssertElementExist(locators._dropHere);
agHelper.AssertElementEnabledDisabled(
debuggerHelper.locators._helpButton,
0,
false,
);
agHelper.Sleep(500);
agHelper.GetNClick(debuggerHelper.locators._helpButton);
agHelper.AssertElementAbsence(OnboardingLocator.introModal);
});
Expand Down

0 comments on commit c079b37

Please sign in to comment.