Skip to content

Commit

Permalink
chore: Renaming feature flags for ME to lower case (appsmithorg#25079)
Browse files Browse the repository at this point in the history
  • Loading branch information
nidhi-nair authored Jul 5, 2023
1 parent 7494c0a commit 5bc0b6f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion app/client/cypress/fixtures/featureFlags.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"success": true
},
"data": {
"DATASOURCE_ENVIRONMENTS": false,
"release_datasource_environments_enabled": false,
"MULTIPLE_PANES": false,
"APP_EMBED_VIEW_HIDE_SHARE_SETTINGS_VISIBILITY": false
}
Expand Down
5 changes: 3 additions & 2 deletions app/client/src/ce/entities/FeatureFlag.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
export const FEATURE_FLAG = {
TEST_FLAG: "TEST_FLAG",
DATASOURCE_ENVIRONMENTS: "DATASOURCE_ENVIRONMENTS",
release_datasource_environments_enabled:
"release_datasource_environments_enabled",
ask_ai: "ask_ai",
APP_NAVIGATION_LOGO_UPLOAD: "APP_NAVIGATION_LOGO_UPLOAD",
ask_ai_sql: "ask_ai_sql",
Expand All @@ -15,7 +16,7 @@ export type FeatureFlags = Record<FeatureFlag, boolean>;

export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = {
TEST_FLAG: true,
DATASOURCE_ENVIRONMENTS: false,
release_datasource_environments_enabled: false,
ask_ai: false,
APP_NAVIGATION_LOGO_UPLOAD: false,
ask_ai_js: false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public enum FeatureFlagEnum {
// ------------------- End of features for testing -------------------------------------------------------------- //

// ------------------- These are actual feature flags meant to be used across the product ----------------------- //
DATASOURCE_ENVIRONMENTS,
release_datasource_environments_enabled,
MULTIPLE_PANES,
APP_NAVIGATION_LOGO_UPLOAD,
APP_EMBED_VIEW_HIDE_SHARE_SETTINGS_VISIBILITY,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<autocreate>false</autocreate>
<audit>false</audit>
<features>
<feature uid="DATASOURCE_ENVIRONMENTS" enable="true"
<feature uid="release_datasource_environments_enabled" enable="true"
description="Introducing multiple execution environments for datasources">
<flipstrategy class="com.appsmith.server.featureflags.strategies.EmailBasedRolloutStrategy">
<param name="emails"
Expand Down

0 comments on commit 5bc0b6f

Please sign in to comment.