Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix view-fit distance for NavCubePlugin #703

Closed
xeolabs opened this issue Aug 4, 2021 · 0 comments
Closed

Fix view-fit distance for NavCubePlugin #703

xeolabs opened this issue Aug 4, 2021 · 0 comments
Assignees
@xeolabs
Labels
bug Something isn't working
Milestone
2.0

Comments

@xeolabs
Copy link
Member

xeolabs commented Aug 4, 2021 •
edited
Loading

When we click on the NavCubePlugin cube, the camera view-fit distance is not the same as that for CameraFlightAnimation#flyTo().

This bug is caused by these two functions using different sources for camera FOV when calculating distance. Fix by making them both use the same FOV source.
@xeolabs xeolabs self-assigned this Aug 4, 2021
@xeolabs xeolabs added the bug Something isn't working label Aug 4, 2021
@xeolabs xeolabs added this to the 2.0 milestone Aug 4, 2021
xeolabs added a commit that referenced this issue Aug 4, 2021
@xeolabs
Fix view-fit distance for NavCubePlugin #703
992f597
@xeolabs xeolabs closed this as completed Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xeolabs xeolabs

Labels
bug Something isn't working
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@xeolabs