Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix size of SectionPlane editing control #480

Closed
Amoki opened this issue Nov 24, 2020 · 5 comments
Closed

Fix size of SectionPlane editing control #480

Amoki opened this issue Nov 24, 2020 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Amoki
Copy link
Contributor

Amoki commented Nov 24, 2020

Describe the bug
Section plane controls are huge:
Capture d’écran de 2020-11-24 16-35-26

And sometimes even bigger:
Capture d’écran de 2020-11-24 16-40-24

I updated to 1.5.13, the problem persists (with and without xkt v6).

To Reproduce
Open our demo model (MarcAntoinePetit.ifc)
Create a section on an axis

sectionPlanesPlugin.createSectionPlane({
  dir: camera.worldRight.map(val => -val),
  pos: math.getAABB3Center(scene.getAABB())
});

Expected behavior
The best behavior may be a constant size of section controls, regardless of zoom.
Just not huge controls are very OK.

Desktop (please complete the following information):
Tried on Linux, latest Firefox and Chromium.

@Amoki
Copy link
Contributor Author

Amoki commented Dec 1, 2020

@xeolabs Do you have any clue? It breaks our section tool :/

@xeolabs
Copy link
Member

xeolabs commented Dec 1, 2020

@Amoki currently the tool sizes itself to the entire model boundary. I'll fix in the next version by sizing it to the view frustum, or something like that.

@xeolabs xeolabs added the bug Something isn't working label Dec 1, 2020
@xeolabs xeolabs self-assigned this Dec 1, 2020
@Amoki
Copy link
Contributor Author

Amoki commented Dec 1, 2020

Just did a bisect: it works in 1.4.7, it's way too big since 1.4.8 (the merge of RTC-coords).

A fix to just bring back the old size is enough for us if doing a dynamic size is hard.

@Amoki
Copy link
Contributor Author

Amoki commented Dec 9, 2020

Hi @xeolabs, It's been 6 weeks since this bug is here, do you have any info about this?

@xeolabs
Copy link
Member

xeolabs commented Dec 9, 2020

@Amoki it's on the list for this week's release

@xeolabs xeolabs changed the title Section plane controls are huge Fix size of SectionPlane editing control Dec 9, 2020
@xeolabs xeolabs added this to the 1.5.12 milestone Dec 9, 2020
@xeolabs xeolabs closed this as completed Dec 9, 2020
@xeolabs xeolabs modified the milestones: 1.5.12, 1.5.2 Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants