Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shading breakage for Phong, metallic and specular materials #410

Closed
xeolabs opened this issue Aug 11, 2020 · 0 comments
Closed

Fix shading breakage for Phong, metallic and specular materials #410

xeolabs opened this issue Aug 11, 2020 · 0 comments
Assignees
@xeolabs
Labels
bug Something isn't working
Milestone
1.3.8

Comments

@xeolabs
Copy link
Member

xeolabs commented Aug 11, 2020 •
edited
Loading

Ambient shading is broken for metallic, phong and specular shaders - see screenshots.

Screenshot from 2020-08-11 19-11-08

Screenshot from 2020-08-11 19-10-53

Screenshot from 2020-08-11 19-10-35
@xeolabs xeolabs added this to the 1.3.8 milestone Aug 11, 2020
@xeolabs xeolabs added the bug Something isn't working label Aug 11, 2020
@xeolabs xeolabs self-assigned this Aug 11, 2020
@xeolabs xeolabs changed the title Metallic and Specular rendering broken for ambient color Ambient shading broken for metallic, phong and specular shaders Aug 11, 2020
@xeolabs xeolabs changed the title Ambient shading broken for metallic, phong and specular shaders Shading broken for metallic, phong and specular rendering Aug 11, 2020
xeolabs added a commit that referenced this issue Aug 11, 2020
@xeolabs
Fix shading for metallic, phong and specular rendering #410
de748c1
@xeolabs xeolabs changed the title Shading broken for metallic, phong and specular rendering Fix shading breakage for phong, metallic and specular materials Aug 11, 2020
@xeolabs xeolabs closed this as completed Aug 11, 2020
@xeolabs xeolabs changed the title Fix shading breakage for phong, metallic and specular materials Fix shading breakage for Phong, metallic and specular materials Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xeolabs xeolabs

Labels
bug Something isn't working
Projects
None yet
Milestone
1.3.8
Development

No branches or pull requests
1 participant
@xeolabs