Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore clicks on disabled ContextMenu items #331

Closed
blickfeld7 opened this issue Jun 8, 2020 · 1 comment
Closed

Ignore clicks on disabled ContextMenu items #331

blickfeld7 opened this issue Jun 8, 2020 · 1 comment
Assignees
@xeolabs
Labels
bug Something isn't working

Comments

@blickfeld7
Copy link

If the getEnabled method of a context menu item returns "false", the html attribute "disabled" is set on that list entry, but the doAction call is still executed on click. This is unexpected and looks like a bug to me.

https://github.com/xeokit/xeokit-sdk/blob/master/src/extras/ContextMenu/ContextMenu.js#L243
@xeolabs xeolabs changed the title unexpected behaviour on getEnabled false on context menu item Ignore clicks on disabled ContextMenu items Jun 8, 2020
xeolabs added a commit that referenced this issue Jun 8, 2020
@xeolabs
Ignore clicks on disabled ContextMenu items
20e857f 
#331
@xeolabs
Copy link
Member

xeolabs commented Jun 8, 2020

Fixed in 20e857f

@xeolabs xeolabs closed this as completed Jun 8, 2020
@xeolabs xeolabs self-assigned this Jun 8, 2020
@xeolabs xeolabs added the bug Something isn't working label Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xeolabs xeolabs

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xeolabs @blickfeld7