Skip to content

Conversation

@innateessence
Copy link

@innateessence innateessence commented Jun 3, 2025

This MR allows users to specify a timeout value for requests. An excerpt from the creators of the request library:
Nearly all production code should use this parameter in nearly all requests. Failure to do so can cause your program to hang indefinitely.

https://docs.python-requests.org/en/latest/user/quickstart/#timeouts

Might be worth setting a default value for this.

I think:

if request_timeout is None:
    request_timeout = (10, 30)

is reasonable but I omitted that

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@innateessence
Copy link
Author

@xente Looks like some check in the CI/CD pipeline isn't passing, if this is an issue that's blocking merging this change, let me know.

Also, if you'd like anything changed, lmk

@xente
Copy link
Owner

xente commented Aug 21, 2025

Hi @innateessence sorry late response.

I have disabled sonarqube by the moment.

Looks like that your change has conflicts. Can you rebase from main, add into the README the new parameter and update the pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants