Skip to content
This repository was archived by the owner on Jul 2, 2025. It is now read-only.

Conversation

@johnelse
Copy link
Contributor

@johnelse johnelse commented Mar 1, 2016

No description provided.

@simonjbeaumont
Copy link
Contributor

discussed a different way of doing this to keep as much logic as possible within this repo so consumers needn't do any config or duplicate any scripts.

@johnelse johnelse force-pushed the cp-15745 branch 2 times, most recently from c057735 to b0263a9 Compare March 1, 2016 17:35
@johnelse johnelse changed the title CP-15745: Add a utility script for building packages under travis CP-15745: Add utility scripts for building packages under travis Mar 1, 2016
@simonjbeaumont
Copy link
Contributor

Also, we may want to consider tagging this repo when you have some scripts that are stable so that the adventurous consumer can wget from master but the cautious can get a stable version. Might enable us to be more free when hacking in this repo without fear of breaking "all the things".

@johnelse
Copy link
Contributor Author

johnelse commented Mar 1, 2016

Indeed. I have a hardcoded wget of the master branch at the moment - would be good to parameterise that too.

@johnelse johnelse force-pushed the cp-15745 branch 2 times, most recently from 9295f40 to 6dc1c11 Compare March 1, 2016 18:26
Signed-off-by: John Else <john.else@citrix.com>
@johnelse
Copy link
Contributor Author

johnelse commented Mar 1, 2016

Removed the hardcoding - it's now possible to override BUILDENV_USER and BUILDENV_BRANCH to get a different version of the build scripts (which incidentally is how I've been testing this).

Signed-off-by: John Else <john.else@citrix.com>
# $REPO_BUILD_CMD (optional - default 'make')
# - The build command to run in the repo.
# $REPO_TEST_CMD (optional - default 'make test')
# - The test command to run in the repo.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice docs 👍

@simonjbeaumont
Copy link
Contributor

Looks good! This is gonna be a great step forward.

simonjbeaumont added a commit that referenced this pull request Mar 2, 2016
CP-15745: Add utility scripts for building packages under travis
@simonjbeaumont simonjbeaumont merged commit 55f1734 into xenserver:master Mar 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants