Incorrect block picking behavior

[Katalijst]

Agreements

• I am using an official build of Nova.
• I am running the latest version of Nova.
• I am using a server software supported by Nova
• I am running the latest version of my server software.
• I have checked for similar issues.

Check for plugin incompatibilites

There are no other plugins running on my server.

Plugin Version, Server Software, Server Version

Nova-0.17-alpha.4 ; paper-1.21.1-81

Nova Addons and Versions

My WIP addon

Expected behavior

If you already have the block in your inventory it just move the selected item to an empty slot of the hotbar and then move your selected slot, or switch with the current selected slot item

Observed/Actual behavior

The normal pick block behavior of minecraft is broken, if you already have the block in your inventory it duplicate to the current selected slot. There is also an induced visual glitch if you have an empty inventory and pick a custom block multiple time, once the hotbar is full and you pick it again you see the normal vanilla block

361928367-42e4f97e-d01b-4c97-a382-0b8da324654d.mp4

Steps to reproduce

Pickup block in creative with empty inventory, custom or vanilla block

Server log

latest.log

Errors

No response

Additional context

No response

[NichtStudioCode]

The ghost item issue has been addressed in ef7f400.

I don't think that the other issues related to creative block picking can be (easily) fixed. This is because in creative mode, there is only ServerboundSetCreativeModeSlotPacket, so Nova has to guess what constitutes a block pick by comparing the currently targeted block to the item that the client wants to add to their inventory. (This already has false positives when you interact with items in your inventory that have the same type as the item of the backing block state you're looking at.)
The main problem that prevents the "more advanced" block picking functionality from being replicated as well is that, in case of a full hotbar, the client moves the previous item stack to a different place in the inventory, but the packet for that is only sent after the player opens their inventory, which would make this quite difficult to track.
While it might be possible to hack something together here, I don't think it's worth the effort, considering the most important functionality (clone the block you're looking at) works fine.