support subscription auth #64
Conversation
|
Seconding this. It's such an obvious feature. |
agent-shell-openai.el
Outdated
| (error "Must specify either :api-key or :login")) | ||
| (cond | ||
| (api-key `((:api-key . ,api-key))) | ||
| ((stringp login) `((:login . t) (:login-method-id . ,login))) |
There was a problem hiding this comment.
Let's get rid of (:login-method-id . ...) and use :login t only for now. Alternatively, it could also be named :chagpt-login. Either work for me.
Internally :login t (or alternative) implies (acp-make-authenticate-request :method-id "chatgpt").
When we have other methods to support, we can add something other than :login.
I know this requries explicitly extending keys later on but will enable us to keep track of what is and isn't supported.
agent-shell-openai.el
Outdated
| :type 'alist | ||
| :group 'agent-shell) | ||
|
|
||
| (defcustom agent-shell-openai-codex-login-authentication-method-id "chatgpt" |
There was a problem hiding this comment.
Same here. We can likely do without this variable and internally :login implies chatgpt.
agent-shell-openai.el
Outdated
| (t | ||
| nil))) | ||
|
|
||
| (defun agent-shell-openai--codex-login-method-id () |
There was a problem hiding this comment.
After previous suggested changes, we won't need this function.
|
Hi there. Still keen to get this merged? Mind sorting out the conflicts? |
3 participants
Vibe coded codex auth via subscription. It's working for me.