Header icon is double the expected size

[jneidel]

TL;DR: Workaround found, no fix required.

Great project! The interface is much superior to the codex TUI :)

Checklist

• I've read the README's Issues section.
• I'm running the latest agent-shell version. (20260116.1925)
• I'm running the latest agent version (ie. Claude Code, Geminig CLI).
• I'm running the latest agent ACP package (ie. claude-code-acp).
• For requesting new agent support, I'm including a link to the ACP-capable agent or related ACP package.
• For issues, I'm including ACP traffic (as per README).

Problem

The agent icon in the header is too large (exactly double) what it should be and is thus overlapping text.

My font is

(set-frame-font "ComicCodeLigatures Nerd Font 13" nil t)

font files in my dotfiles

Workaround

I already found a workaround for this, so I don't require a fix. Feel free to close this issue.
Just posting this for awareness :)

(with-eval-after-load 'agent-shell
  (require 'cl-lib)
  (advice-add
   'agent-shell--make-header :around
   (lambda (fn state &rest args)
     (let ((orig-default-font-height (symbol-function 'default-font-height)))
       (cl-letf (((symbol-function 'default-font-height)
                  (lambda (&rest fh-args)
                    (* 0.5 (apply orig-default-font-height fh-args)))))
         (apply fn state args))))))

This code corrects the icon size without any side effects (that I have noticed).
See:

[xenodium]

Thanks for filing with all the details and providing a workaround!

Great project! The interface is much superior to the codex TUI :)

Thank you. That's nice to hear!

The size calculation isn't very reliable at the moment. I'm wondering if we can avoid the workaround altogether with something like this:

            ;; |      | Bottom text line
            ;; +------+
            ;; [Qualifier] Bindings row (optional, last row)
-           (let* ((image-height (* 3 (default-font-height)))
+           (let* ((image-height (* 2.1 (frame-char-height)))
                   (image-width image-height)
                   (text-height 25)
                   (row-spacing 0)  ; Spacing between icon/text rows and bindings row

Mind giving this a try?

[jneidel]

(let* ((image-height (* 2.1 (frame-char-height)))

With this the icon is smaller, but does not look quite right yet.

Setting it to 1.5 (half of 3, which I knew to be the correct ratio for me) make it look as it should. I don't know how this might affect a system which did not have my problem in the first place :)

(let* ((image-height (* 1.5 (frame-char-height)))

[xenodium]

Thanks for this. (frame-char-height) is responsive to global-text-scale-adjust, so it's somewhat an improvement. Having said that, the magic constant isn't great still as its unlikely to work for all. I'll keep this issue open for now.