drivers: ramdisk: Add support for external initrd #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drivers/disk/ramdisk.c
Outdated
Collaborator
There was a problem hiding this comment.
Why can't you put ramdisk_buf here with explicit casting for suppressing warnings and reduce the diff?
Collaborator
|
Review finished, generally ok. |
Add support for using initrd provided by the bootloader as the RAM Disk. Location of the initrd is specified by the DISK_RAM_START Kconfig option. Currently only uncompressed filesystem images are supported. Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
Add lz4frame and xxhash to the build system. This is required to support the decompression of LZ4 files made with LZ4 cli tool. Base lz4 library only supports decompression of raw LZ4 blocks without taking into account the frame metadata. Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
Deedone
force-pushed
the
initrd
branch
2 times, most recently
from
1ce52b6 to
4820117
Compare
firscity
reviewed
Feb 23, 2024
drivers/disk/ramdisk.c
Outdated
Collaborator
There was a problem hiding this comment.
Should we include it unconditionally to this file? Also should it be #include "" instead of #include <>?
Author
There was a problem hiding this comment.
Regarding " vs < it was included with " in a sample for some reason so I assumed that it is required, changed to <
Add support for decompressing the initrd before using it as the RAM Disk. For now, only LZ4 compression is supported. It is advised to use smaller block sizes for the compressed initrd to reduce the size of heap memory required for decompression. Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
Collaborator
|
Are we going to merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for using initrd provided by the bootloader. Supports both compressed and uncompressed filesystem images.