added function to handle version command line argument. Fixes #352 #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeco23
requested changes
Dec 13, 2023
| @@ -12,6 +16,23 @@ namespace | |||
| } | |||
| } | |||
|
|
|||
| void handleVersionCommandLineOption(int argc, char** argv, bool& version) | |||
There was a problem hiding this comment.
Could we move all the code into the Application class to make it cleaner? It also has access to argc and argv. Maybe even better, we can properly set the HANDLES_COMMAND_LINE flag and react on on_command_line of the Gtk::Application by overriding it like it's done here in the first answer: https://stackoverflow.com/questions/13852421/gtkmm-3-parse-command-line-with-gtkapplication
| @@ -12,6 +16,23 @@ namespace | |||
| } | |||
| } | |||
|
|
|||
| void handleVersionCommandLineOption(int argc, char** argv, bool& version) | |||
| { | |||
| Glib::OptionGroup optionGroup("options", "Command Line Options", "Show command line options"); | |||
There was a problem hiding this comment.
Please use auto. This applies to all other variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #352
Proposed Changes
handleVersionCommandLineOptionto handle the--versionand-vcommand line options.