Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop deleting AE's on drop from compendium #1649

Merged
merged 4 commits into from
Oct 1, 2024
Merged

fix: stop deleting AE's on drop from compendium #1649

merged 4 commits into from
Oct 1, 2024

Conversation

marvin9257
Copy link
Collaborator

@marvin9257 marvin9257 commented Sep 30, 2024 •
edited
Loading

  • Please check if the PR fulfills these requirements

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fixes

  • What is the current behavior? (You can also link to an open issue here)

  • Problem when dropping item from compendium when item AE setting is not active
  • Item AE setting false by default
  • No description when rolling consciousness check
  • What is the new behavior (if this is a feature change)?
  • Allow drop and keep AE's when item AE setting off
  • Item AE setting default is true
  • Add flavor message to unconsciousness rolls.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@marvin9257 marvin9257 changed the title fix: error on item copy fix: stop deleting AE's on drop from compendium Sep 30, 2024
@marvin9257 marvin9257 merged commit 804b0cd into xdy:master Oct 1, 2024
8 checks passed
@marvin9257 marvin9257 deleted the fix-drop-from-compendium-error branch October 1, 2024 20:31
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
@semantic-release-bot
chore(release): 5.8.5 [skip ci]
d2da857 
## [5.8.5](v5.8.4...v5.8.5) (2024-10-01)

### Bug Fixes

* Item Active Effect Improvements ([#1649](#1649)) ([804b0cd](804b0cd))
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

🎉 This issue has been resolved in version 5.8.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marvin9257