Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve compatibility with CE and Clement Sector rules #1534

Merged
merged 11 commits into from
Jan 18, 2024

Conversation

marvin9257
Copy link
Collaborator

@marvin9257 marvin9257 commented Jan 14, 2024

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    Encumbrance rules only have one tier (fixed encumbrance DM value)
    Can't rename j-drive

  • What is the new behavior (if this is a feature change)?
    For CE Rules, recognize two-tier encumbrance
    New setting to relabel j-drive (e.g. z-drive)

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:
    Add support for Clement Sector from Independence Games #459 This change will allow better compatibility for CS encumbrance modifiers as it now follows the CE rules better.

Copy link
Collaborator Author

@marvin9257 marvin9257 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

src/module/hooks/showStatusIcons.ts Outdated Show resolved Hide resolved
src/module/hooks/showStatusIcons.ts Show resolved Hide resolved
src/module/hooks/showStatusIcons.ts Outdated Show resolved Hide resolved
@marvin9257 marvin9257 changed the title WIP feat: initial cut at CE encumbrance rules feat: initial cut at CE encumbrance rules Jan 15, 2024
@marvin9257 marvin9257 changed the title feat: initial cut at CE encumbrance rules feat: Improve compatibility with CE and Clement Sector rules Jan 15, 2024
@marvin9257 marvin9257 merged commit 94668b8 into xdy:master Jan 18, 2024
8 checks passed
@marvin9257 marvin9257 deleted the incorporate-CE-encumbrance-rules branch January 18, 2024 17:45
github-actions bot pushed a commit that referenced this pull request Jan 18, 2024
# [4.19.0](v4.18.3...v4.19.0) (2024-01-18)

### Features

* Improve compatibility with CE and Clement Sector rules ([#1534](#1534)) ([94668b8](94668b8))
Copy link

🎉 This PR is included in version 4.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant