-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve compatibility with CE and Clement Sector rules #1534
Merged
marvin9257
merged 11 commits into
xdy:master
from
marvin9257:incorporate-CE-encumbrance-rules
Jan 18, 2024
Merged
feat: Improve compatibility with CE and Clement Sector rules #1534
marvin9257
merged 11 commits into
xdy:master
from
marvin9257:incorporate-CE-encumbrance-rules
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin9257
commented
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
marvin9257
changed the title
WIP feat: initial cut at CE encumbrance rules
feat: initial cut at CE encumbrance rules
Jan 15, 2024
marvin9257
changed the title
feat: initial cut at CE encumbrance rules
feat: Improve compatibility with CE and Clement Sector rules
Jan 15, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
# [4.19.0](v4.18.3...v4.19.0) (2024-01-18) ### Features * Improve compatibility with CE and Clement Sector rules ([#1534](#1534)) ([94668b8](94668b8))
🎉 This PR is included in version 4.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
Encumbrance rules only have one tier (fixed encumbrance DM value)
Can't rename j-drive
What is the new behavior (if this is a feature change)?
For CE Rules, recognize two-tier encumbrance
New setting to relabel j-drive (e.g. z-drive)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Add support for Clement Sector from Independence Games #459 This change will allow better compatibility for CS encumbrance modifiers as it now follows the CE rules better.